Conversation
Contributor
4 tasks
graingert
reviewed
Mar 7, 2022
Comment on lines
+64
to
+65
| # stacktrace for Python 3.8+ has not been released at the moment of writing | ||
| if: ${{ matrix.os == 'ubuntu-latest' && matrix.python-version == '3.7' }} |
Member
There was a problem hiding this comment.
now that 3.7 has been dropped from CI - does this mean that use of libunwind and stacktrace should be removed?
Collaborator
There was a problem hiding this comment.
Member
|
@jrbourbeau I think merging main and merging #5353 into this will cause the tests to pass |
crusaderky
reviewed
Mar 9, 2022
crusaderky
reviewed
Mar 9, 2022
| # - git+https://github.com/intake/filesystem_spec | ||
| - git+https://github.com/joblib/joblib | ||
| - keras | ||
| - pytest-asyncio<0.14.0 # `pytest-asyncio<0.14.0` isn't available on conda-forge for Python 3.10 |
Collaborator
There was a problem hiding this comment.
the env file for Python 3.9 should be updated to not include these git tips anymore
Member
Author
|
Looks like this was superseded by #5952 -- thanks for taking over @graingert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-files